From 4fa7bf01170974442f82ef8de6138faef7edefaa Mon Sep 17 00:00:00 2001 From: Wayne Warthen Date: Tue, 22 Jul 2025 11:42:39 -0700 Subject: [PATCH] Note Terminology Follow-up, Issue #595 Trying to ferret out the last instances of quarter-note being used instead of eighth-note. The comments in `audio.inc` are now confusing, but I don't know how to fix them... --- Source/Apps/Tune/hbios.inc | 2 +- Source/HBIOS/audio.inc | 2 +- Source/HBIOS/hbios.inc | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Source/Apps/Tune/hbios.inc b/Source/Apps/Tune/hbios.inc index cba06045..a7d3351e 100644 --- a/Source/Apps/Tune/hbios.inc +++ b/Source/Apps/Tune/hbios.inc @@ -7,6 +7,6 @@ BF_SND .EQU $50 BF_SNDRESET .EQU BF_SND + 0 ; RESET SOUND SYSTEM BF_SNDVOL .EQU BF_SND + 1 ; REQUEST SOUND VOL - L CONTAINS VOLUME (255 MAX, 0 SILENT) - SCALED AS REQUIRED BY DRIVER (EG: MAPS TO JUST 4 BIT RESOLUTION FOR SN76489) BF_SNDPRD .EQU BF_SND + 2 ; REQUEST SOUND PERIOD - HL CONTAINS DRIVER SPECIFIC VALUE -BF_SNDNOTE .EQU BF_SND + 3 ; REQUEST NOTE - L CONTAINS NOTE - EACH VALUE IS QUARTER NOTE +BF_SNDNOTE .EQU BF_SND + 3 ; REQUEST NOTE - L CONTAINS NOTE - EACH VALUE IS AN EIGHTH NOTE BF_SNDPLAY .EQU BF_SND + 4 ; INITIATE THE REQUESTED SOUND COMMAND BF_SNDQUERY .EQU BF_SND + 5 ; E IS SUBFUNCTION diff --git a/Source/HBIOS/audio.inc b/Source/HBIOS/audio.inc index fcb686c7..91352a3e 100644 --- a/Source/HBIOS/audio.inc +++ b/Source/HBIOS/audio.inc @@ -45,7 +45,7 @@ AUD_SCALE .EQU 3 ; ON ENTRY, DE IS ADDRESS OF NOTE TABLE, HL IS NOTE TO PLAY ; NOTE VALUE 0 MEANS B0b/A0# IN OCTAVE 0 WHICH IS THE FIRST ENTRY ; OF THE NOTE TABLE. THE NOTE TABLE REPRESENTS THE FREQUENCIES -; FOR 1 FULL OCTAVE IN QUARTER NOTES. SINCE THERE ARE 12 NOTES +; FOR 1 FULL OCTAVE IN EIGHTH NOTES. SINCE THERE ARE 12 NOTES ; IN AN OCTAVE, THE TABLE HAS 48 ENTRIES FOR ALL QUARTER NOTES. ; ; ON EXIT, HL CONTAINS THE PERIOD VALUE TO PROGRAM INTO THE PSG diff --git a/Source/HBIOS/hbios.inc b/Source/HBIOS/hbios.inc index 3c7a42f5..c58fbf39 100644 --- a/Source/HBIOS/hbios.inc +++ b/Source/HBIOS/hbios.inc @@ -71,7 +71,7 @@ BF_SND .EQU $50 BF_SNDRESET .EQU BF_SND + 0 ; RESET SOUND SYSTEM BF_SNDVOL .EQU BF_SND + 1 ; REQUEST SOUND VOL - L CONTAINS VOLUME (255 MAX, 0 SILENT) - SCALED AS REQUIRED BY DRIVER (EG: MAPS TO JUST 4 BIT RESOLUTION FOR SN76489) BF_SNDPRD .EQU BF_SND + 2 ; REQUEST SOUND PERIOD - HL CONTAINS DRIVER SPECIFIC VALUE -BF_SNDNOTE .EQU BF_SND + 3 ; REQUEST NOTE - L CONTAINS NOTE - EACH VALUE IS QUARTER NOTE +BF_SNDNOTE .EQU BF_SND + 3 ; REQUEST NOTE - L CONTAINS NOTE - EACH VALUE IS AN EIGHTH NOTE BF_SNDPLAY .EQU BF_SND + 4 ; INITIATE THE REQUESTED SOUND COMMAND BF_SNDQUERY .EQU BF_SND + 5 ; E IS SUBFUNCTION BF_SNDDURATION .EQU BF_SND + 6 ; REQUEST DURATION HL MILLISECONDS