From 92bdce5eb1f2872886f7296a87e559701183f43e Mon Sep 17 00:00:00 2001 From: Wayne Warthen Date: Wed, 12 Dec 2018 15:37:24 -0800 Subject: [PATCH] Small PPIDE Driver Fix Remove use of IDE NOP command during probe. --- Source/HBIOS/ppide.asm | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/Source/HBIOS/ppide.asm b/Source/HBIOS/ppide.asm index e6bcb560..56a755c5 100644 --- a/Source/HBIOS/ppide.asm +++ b/Source/HBIOS/ppide.asm @@ -965,13 +965,11 @@ PPIDE_PROBE: ; THE PPI BUS HOLD WILL RETURN A VALUE OF ZERO IF THERE IS ; NOTHING CONNECTED TO PPI PORT A. THEN WE READ THE STATUS ; REGISTER. IF AN IDE CONTROLLER IS THERE, IT SHOULD ALWAYS - ; RETURN SOMETHING OTHER THAN ZERO. NOTE THAT REG_STAT IS - ; ALSO THE COMMAND REGISTER FOR THE IDE CONTOLLER, BUT A - ; COMMAND VALUE OF ZERO IS A NOP, SO IT DOES NO HARM IF AN - ; IDE CONTOLLER IS THERE AND SEES IT. + ; RETURN SOMETHING OTHER THAN ZERO. IF AN IDE CONTROLLER IS + ; THERE, THEN THE VALUE WRITTEN TO PPI PORT A IS IGNORED + ; BECAUSE THE WRITE SIGNAL IS NEVER PULSED. XOR A - CALL PPIDE_OUT - .DB PPIDE_REG_STAT + OUT (PPIDE_IO_DATALO),A CALL PPIDE_IN .DB PPIDE_REG_STAT DCALL PC_SPACE